Add support for Quarto integration #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Oct 10, 2023
jcheng5
reviewed
Oct 10, 2023
wch
commented
Oct 10, 2023
| @@ -89,7 +97,7 @@ def server(input: Inputs, output: Outputs, session: Session): | |||
|
|
|||
| def __init__( | |||
| self, | |||
| ui: Tag | TagList | Callable[[Request], Tag | TagList], | |||
| ui: Tag | TagList | Callable[[Request], Tag | TagList] | Path, | |||
There was a problem hiding this comment.
@jcheng5 What do you think about taking a Path object to indicate that it should read the UI from a file?
schloerke
added a commit
that referenced
this pull request
Oct 13, 2023
* main: Remove leading newline Stop testing on Python 3.12 Update changelog Check that file is autogenerated before overwriting Run tests on Python 3.12 Add support for Quarto integration (#746) Revert inadvertent whitespace change Update shinylive version for docs (#759) Self outputting renderers (#747)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using Shiny in a Quarto document.
It also requires posit-dev/py-htmltools#61